Differential D22975

[GridDelegate] Don't select unselected item when clicking on any of its action buttons
ClosedPublic
Actions

Authored by ngraham on Aug 6 2019, 6:11 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R296:661695fdc532: [GridDelegate] Don't select unselected item when clicking on any of its action…
Summary

In 6258f33fce3af55f7cdd3b5487cd04d8e53c0b38, I changed the delegate action button
behavior to select an unselected item when any of its buttons were clicked. In
retrospect, this was a mistake and causes various issues with items becoming selected
when they shouldn't be.

This patch reverts that part of the change to the prior behavior.

BUG: 404536
FIXED-IN: 5.62

Test Plan

Preview an unselected LNF theme or splash screen and navigate away from the KCM; no
"unsaved changes" dialog

Click on the delete or show in folder button on an unselected wallpaper item; still works

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Aug 6 2019, 6:11 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 6 2019, 6:11 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 6 2019, 6:11 PM
ngraham edited the summary of this revision. (Show Details)Aug 6 2019, 6:17 PM
broulik accepted this revision.Aug 6 2019, 6:21 PM
This revision is now accepted and ready to land.Aug 6 2019, 6:21 PM
Closed by commit R296:661695fdc532: [GridDelegate] Don't select unselected item when clicking on any of its action… (authored by ngraham). · Explain WhyAug 6 2019, 6:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63221

View Options

src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

Loading...