Differential D22966

Wayland: backend code cleanup
ClosedPublic
Actions

Authored by romangg on Aug 6 2019, 1:31 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R110:479d07200861: Wayland: backend code cleanup
Summary

Modernize code, make it more readable, throw away unused code.

Test Plan

Compiles, runs.

Diff Detail

Repository
R110 KScreen Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Aug 6 2019, 1:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 6 2019, 1:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Aug 6 2019, 1:31 PM
zzag added a subscriber: zzag.Aug 6 2019, 2:00 PM
zzag added inline comments.
backends/kwayland/waylandconfig.h
73

If libkscreen follows the Frameworks or the Kdelibs coding style, then WaylandOutput and * have to be separated by a space. See source code of Qt for more examples.

Qt Coding Style and Frameworks Coding Style are similar except a minor detail - braces.

romangg added inline comments.Aug 6 2019, 2:51 PM
backends/kwayland/waylandconfig.h
73

Doesn't follow it. I have sent a mail to frameworks list though about the topic.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 7 2019, 7:38 AM
Closed by commit R110:479d07200861: Wayland: backend code cleanup (authored by romangg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63254

View Options

backends/kwayland/waylandbackend.h

Loading...
View Options

backends/kwayland/waylandbackend.cpp

Loading...
View Options

backends/kwayland/waylandconfig.h

Loading...
View Options

backends/kwayland/waylandconfig.cpp

Loading...
View Options

backends/kwayland/waylandoutput.h

Loading...
View Options

backends/kwayland/waylandoutput.cpp

Loading...