[ColorButton] Forward accepted signal from ColorDialog
ClosedPublic

Authored by broulik on Aug 6 2019, 11:53 AM.

Details

Summary

Allows to react to the user explicitly accepting the dialog and picking a color.
While there is a currentColor vs color property on the ColorDialog, you can still end up with unexpected change signal emissions when the underlying model changes. This signal is only ever emitted when the ColorDialog is accepted.

Test Plan

Clicked the button, chose a color, clicked OK, got accepted emitted with the picked color

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Aug 6 2019, 11:53 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 6 2019, 11:53 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
broulik requested review of this revision.Aug 6 2019, 11:53 AM
mart accepted this revision.Aug 6 2019, 11:54 AM
This revision is now accepted and ready to land.Aug 6 2019, 11:54 AM
This revision was automatically updated to reflect the committed changes.