Rolloff roof handling introduced
ClosedPublic

Authored by wreissenberger on Aug 5 2019, 7:21 PM.

Details

Summary

Rolloff roofs need a slightly different approach than domes. Parking and unparking of rolloff roofs use the "move clockwise" for opening and "move counter clockwise" for closing the roof. The following features are implemented:

  • park roof
  • unpark roof
  • open roof
  • close roof
  • abort motion

Additionally, the motion functionality is added for domes as well.

Test Plan

Since I can use only the rolloff roof simulator, a test in the real environment is of top priority.

Diff Detail

Repository
R321 KStars
Branch
observatory_rolloff_roof
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14777
Build 14795: arc lint + arc unit
wreissenberger created this revision.Aug 5 2019, 7:21 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 5 2019, 7:21 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Aug 5 2019, 7:21 PM

Great work Wolfgang! I have a rolloff roof so I will be definitely live testing this very soon!

Please make the necessary changes as per the comments.

kstars/auxiliary/ksutils.cpp
1042

Why is this here and not with the rest of the modules above?

kstars/ekos/auxiliary/dome.cpp
101–102

This function could be simplified to one line:

return (currentDome && !currentDome->canAbsMove() && !currentDome->canRelMove()))

kstars/ekos/auxiliary/opslogs.ui
408

missing tooltip

kstars/ekos/observatory/observatory.cpp
266

i18n

270

CLOSING --> Closing...

281

i18n?

285

Ditto

317

OPEN --> Open

No need to capitalize unless extremely necessary for dangerous situations like CAUTION or something like that.

565

No need to use i18n here, the i18n should be used on string literals i18n("Foo") and not on variables.

So this should be setText(titleCounterpart) and the calling function should use the i18n

mutlaqja requested changes to this revision.Aug 7 2019, 6:13 PM
This revision now requires changes to proceed.Aug 7 2019, 6:13 PM
wreissenberger marked 9 inline comments as done.

Proposed code cosmetics added

wreissenberger added inline comments.Aug 7 2019, 8:47 PM
kstars/auxiliary/ksutils.cpp
1042

arg can carry at most 9 arguments. Therefore I had to split it.

kstars/ekos/auxiliary/dome.cpp
101–102

OK.

kstars/ekos/auxiliary/opslogs.ui
408

Yepp, done.

kstars/ekos/observatory/observatory.cpp
270

Good point.

285

Agreed.

565

OK, sounds reasonable.

mutlaqja accepted this revision.Aug 8 2019, 12:40 AM
This revision is now accepted and ready to land.Aug 8 2019, 12:40 AM
This revision was automatically updated to reflect the committed changes.