Differential D22940

Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent
ClosedPublic
Actions

Authored by GB_2 on Aug 5 2019, 8:37 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Maniphest Tasks
T10862: Make QML imports consistent
Commits
R120:b4ccffec69ec: Add label to the lockscreen config's "Show media controls" checkbox and make…
Summary

Test Plan

Open the Appearance tab of the Screen Locking KCM

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Aug 5 2019, 8:37 AM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 5 2019, 8:37 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
GB_2 requested review of this revision.Aug 5 2019, 8:37 AM
GB_2 retitled this revision from Add a label to the lockscreen config's "Show media controls" checkbox and make the QML imports consistent to Add label to the lockscreen config's "Show media controls" checkbox and make QML imports consistent.Aug 5 2019, 8:39 AM
GB_2 edited the summary of this revision. (Show Details)Aug 5 2019, 1:35 PM
GB_2 updated this revision to Diff 63117.EditedAug 5 2019, 1:37 PM

Put checkbox id property above text property

ngraham requested changes to this revision.Aug 5 2019, 2:08 PM
ngraham added a subscriber: ngraham.
ngraham added inline comments.
lookandfeel/contents/lockscreen/config.qml
17

This short string needs translation context. Is "Show" a verb or a noun? Translators won't be able to tell.

This revision now requires changes to proceed.Aug 5 2019, 2:08 PM
GB_2 updated this revision to Diff 63125.Aug 5 2019, 2:33 PM

Add translation context

ngraham accepted this revision.Aug 5 2019, 2:46 PM
This revision is now accepted and ready to land.Aug 5 2019, 2:46 PM
Closed by commit R120:b4ccffec69ec: Add label to the lockscreen config's "Show media controls" checkbox and make… (authored by GB_2). · Explain WhyAug 5 2019, 2:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63129

View Options

lookandfeel/contents/lockscreen/config.qml

Loading...