[kcmkwin/kwindesktop] Improve the look of the Virtual Desktops KCM UI
ClosedPublic

Authored by GB_2 on Aug 4 2019, 6:57 PM.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Aug 4 2019, 6:57 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 4 2019, 6:57 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
GB_2 requested review of this revision.Aug 4 2019, 6:57 PM
hein accepted this revision.Aug 4 2019, 7:04 PM
This revision is now accepted and ready to land.Aug 4 2019, 7:04 PM
ngraham requested changes to this revision.Aug 4 2019, 9:44 PM
ngraham added a subscriber: ngraham.

Could we put the Rows spinbox on the other side of the list with whitespace between it and the plus button maybe? Otherwise I feel that by putting it right next to the plus button, we'd be creating a visual connection between the two that isn't accurate.

This revision now requires changes to proceed.Aug 4 2019, 9:44 PM
broulik added a subscriber: broulik.Aug 5 2019, 7:32 AM

I think the "Add new desktop" button must be a lot more prominent?

GB_2 updated this revision to Diff 63098.Aug 5 2019, 8:04 AM
  • Put the Rows spinbox on the other side of the list
  • Use a label for the Add button instead of a tooltip, because it's the only button
GB_2 edited the summary of this revision. (Show Details)Aug 5 2019, 8:07 AM
ngraham accepted this revision.Aug 5 2019, 2:55 PM

Thanks!

This revision is now accepted and ready to land.Aug 5 2019, 2:55 PM
This revision was automatically updated to reflect the committed changes.