Differential D22924

[Night Color KCM] Don't show advanced controls for constant mode
ClosedPublic
Actions

Authored by zzag on Aug 4 2019, 12:44 PM.

Details

Reviewers
GB_2
ngraham
Group Reviewers
Plasma
VDG
Commits
R119:bf1009cf1973: [Night Color KCM] Don't show advanced controls for constant mode
Summary

The user can only change the color temperature when the constant mode is
selected. Therefore, it doesn't make sense to display all irrelevant input
controls (e.g. latitude and longitude inputs, etc).

Test Plan


Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Aug 4 2019, 12:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 4 2019, 12:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Aug 4 2019, 12:44 PM
zzag edited the test plan for this revision. (Show Details)Aug 4 2019, 12:48 PM
GB_2 accepted this revision as: VDG, GB_2.Aug 4 2019, 12:52 PM
This revision is now accepted and ready to land.Aug 4 2019, 12:52 PM
ngraham accepted this revision.Aug 4 2019, 2:27 PM
zzag added a comment.Aug 4 2019, 2:47 PM

I'll land this patch in 24h if there are no objections from Plasma.

Closed by commit R119:bf1009cf1973: [Night Color KCM] Don't show advanced controls for constant mode (authored by zzag). · Explain WhyAug 6 2019, 10:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63166

View Options

kcms/nightcolor/package/contents/ui/main.qml

Loading...