Use standard icon names
ClosedPublic

Authored by astippich on Aug 4 2019, 10:40 AM.

Details

Summary

Try to avoid icon names containing "amarok" in order to
use more common icon names, which they are symlink of.
Only remaining icon is "media-show-active-track-amarok"
for which there is no standard replacement.

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Aug 4 2019, 10:40 AM
astippich created this revision.
mgallien accepted this revision.Aug 4 2019, 1:46 PM

Looks fine to me.
Thanks

This revision is now accepted and ready to land.Aug 4 2019, 1:46 PM
ngraham accepted this revision.Aug 4 2019, 5:48 PM

In 48e020419201bc7dfb4066135a0341320bd82ea7 I've renamed the final icon to media-track-show-active (with a compatibility symlink for the old name so nothing will break). So once Elisa can depend on Frameworks 5.62, you can change media-show-active-track-amarok to media-track-show-active.

Awesome, thanks!

This revision was automatically updated to reflect the committed changes.