Differential D22916

Include ECMGeneratePriFile after KDEInstallDirs
ClosedPublic
Actions

Authored by arojas on Aug 4 2019, 10:11 AM.

Details

Reviewers
apol
kossebau
Commits
R216:1ad9586d1d90: Include KDE* cmake macros first
Summary

ECMGeneratePriFile uses KDE_INSTALL_USE_QT_SYS_PATH, which is initialized in KDEInstallDirs, to determine the mkspecs install dir

Test Plan

Build 5.61 without setting CMAKE_INSTALL_PREFIX, pri file is installed in the right place

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas created this revision.Aug 4 2019, 10:11 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptAug 4 2019, 10:11 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
arojas requested review of this revision.Aug 4 2019, 10:11 AM
arojas updated this revision to Diff 63056.Aug 4 2019, 11:52 AM
arojas added a reviewer: kossebau.

Implement kossebau's suggestion from D22915

kossebau accepted this revision.Aug 4 2019, 12:49 PM

You might want to adapt the commit message/phab revision title perhaps, noting that those three includes should be done first, as they want to influence any other CMake code used by the project,

This revision is now accepted and ready to land.Aug 4 2019, 12:49 PM
Closed by commit R216:1ad9586d1d90: Include KDE* cmake macros first (authored by arojas). · Explain WhyAug 4 2019, 12:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (7 lines)

Diff 63056

View Options

CMakeLists.txt

Loading...