[kcmkwin/kwineffects] Improve the look of the Desktop Effects KCM list items
ClosedPublic

Authored by GB_2 on Aug 4 2019, 9:31 AM.

Details

Summary

Tweak spacing and margins, improve the look of headers and descriptions.

Test Plan

Open the Desktop Effects KCM and hover over a list item.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Aug 4 2019, 9:31 AM
Restricted Application added a project: KWin. · View Herald TranscriptAug 4 2019, 9:31 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
GB_2 requested review of this revision.Aug 4 2019, 9:31 AM
GB_2 edited the summary of this revision. (Show Details)Aug 4 2019, 9:32 AM
GB_2 updated this revision to Diff 63041.Aug 4 2019, 9:35 AM

Also set opacity for about label

GB_2 edited the summary of this revision. (Show Details)Aug 4 2019, 9:36 AM
ngraham added a subscriber: ngraham.EditedAug 4 2019, 1:45 PM

+1 for the extra vertical spacing. +1 for using a Kirigami Heading, which is semantically appropriate here.

Even though I don't like it, I won't turn this patch into a vehicle for complaining about our allergy to bold header text. :) However I will leave this screenshot here:

Doesn't it noticeably improve the visual hierarchy to make the category headers bold? Making the text slightly larger (size 3 to size 2) doesn't cut it IMO. In fact I think there's really not enough visual difference between size 3 and size 2 in general, while the gap between 2 and 1 is huge.

ngraham accepted this revision.Aug 4 2019, 1:46 PM
This revision is now accepted and ready to land.Aug 4 2019, 1:46 PM
This revision was automatically updated to reflect the committed changes.