Fix build with clang 9.0
ClosedPublic

Authored by bero on Aug 3 2019, 8:51 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Latte Dock
Summary

Without this patch, trying to build latte-dock with clang 9.0 results in:

`../app/settings/delegates/persistentmenu.cpp:23:41: error: addition of default argument on redeclaration makes this constructor a default constructor
PersistentMenu::PersistentMenu(QWidget *parent = 0)

^        ~

../app/settings/delegates/persistentmenu.h:31:3: note: previous declaration is here

PersistentMenu(QWidget *parent);
^

1 error generated.
`

Test Plan

Install clang 9.0-rc1, try to build latte-dock, see if it succeeds

Diff Detail

Repository
R878 Latte Dock
Lint
Lint Skipped
Unit
Unit Tests Skipped
bero created this revision.Aug 3 2019, 8:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 3 2019, 8:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bero requested review of this revision.Aug 3 2019, 8:51 PM
bero edited the summary of this revision. (Show Details)Aug 3 2019, 9:02 PM
davidedmundson accepted this revision.Aug 21 2019, 10:02 AM
This revision is now accepted and ready to land.Aug 21 2019, 10:02 AM