Adds a placeholder text and uses contentItem
Details
Details
- Reviewers
ngraham apol - Group Reviewers
Okular Plasma: Mobile - Commits
- R223:230ae9affee5: Improve search field
Diff Detail
Diff Detail
- Repository
- R223 Okular
- Branch
- improve-searchfield
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 14704 Build 14722: arc lint + arc unit
Comment Actions
Use Kirigami.SearchField instead; it takes care of everything for you. You'll need to import Kirigami 2.8 or later for this.
Also the changes to ThumbnailsBase.qml are unrelated to the subject; please do them in another patch (or just commit directly since it's so minor).
mobile/app/package/contents/ui/Thumbnails.qml | ||
---|---|---|
32–33 | Placeholder text should just be "Search..." Use three dots instead of the ellipsis character |