Improve search field
ClosedPublic

Authored by jbbgameich on Aug 2 2019, 9:15 PM.

Details

Summary

Adds a placeholder text and uses contentItem

Diff Detail

Repository
R223 Okular
Branch
improve-searchfield
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14704
Build 14722: arc lint + arc unit
jbbgameich created this revision.Aug 2 2019, 9:15 PM
Restricted Application added a project: Okular. · View Herald TranscriptAug 2 2019, 9:15 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
jbbgameich requested review of this revision.Aug 2 2019, 9:15 PM
ngraham requested changes to this revision.Aug 3 2019, 1:41 AM
ngraham added a subscriber: ngraham.

Use Kirigami.SearchField instead; it takes care of everything for you. You'll need to import Kirigami 2.8 or later for this.

Also the changes to ThumbnailsBase.qml are unrelated to the subject; please do them in another patch (or just commit directly since it's so minor).

This revision now requires changes to proceed.Aug 3 2019, 1:41 AM
jbbgameich updated this revision to Diff 63012.Aug 3 2019, 7:43 AM

Use Kirigami.SearchField

jbbgameich updated this revision to Diff 63014.Aug 3 2019, 7:44 AM

Remove unrelated changes

jbbgameich updated this revision to Diff 63015.Aug 3 2019, 7:46 AM

actually remove unrelated changes

ognarb added a subscriber: ognarb.Aug 3 2019, 10:25 AM

See discussion in D18658, Okular depends on Framework 5.44

I see. @ngraham should I revert the change to use Kirigami.SearchField again then?

Sigh, I guess so

jbbgameich updated this revision to Diff 63039.Aug 4 2019, 8:28 AM

revert back to Controls TextField

ngraham added inline comments.Aug 4 2019, 5:28 PM
mobile/app/package/contents/ui/Thumbnails.qml
32–33

Placeholder text should just be "Search..."

Use three dots instead of the ellipsis character

jbbgameich updated this revision to Diff 63084.Aug 4 2019, 6:53 PM

Update searchField text to defaults of Kirigami.SearchField

ngraham accepted this revision.Aug 4 2019, 9:45 PM

LGTM!

This revision is now accepted and ready to land.Aug 4 2019, 9:45 PM
apol accepted this revision.Aug 5 2019, 12:51 AM
jbbgameich closed this revision.Aug 5 2019, 5:07 AM