Differential D22902

[android] Add helper for building libical
AbandonedPublic
Actions

Authored by nicolasfella on Aug 2 2019, 4:44 PM.

Details

Reviewers
apol
Summary

libical is needed for building kcalcore which is needed to build calindori.

I sent two patches to libical to support building on Android that are merged now https://github.com/libical/libical/pull/405 https://github.com/libical/libical/pull/403

Diff Detail

Repository
R857 CI System Tooling
Branch
libical
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14688
Build 14706: arc lint + arc unit
nicolasfella requested review of this revision.Aug 2 2019, 4:44 PM
nicolasfella created this revision.
nicolasfella edited the summary of this revision. (Show Details)Aug 3 2019, 3:39 PM
apol added a comment.Aug 3 2019, 6:46 PM

Not that I'm against having it, but if it's a matter of just building libical with a couple of arguments, maybe it's easier to hardcode it as a dependency?
https://phabricator.kde.org/source/sysadmin-binary-factory-tooling/browse/master/android/current-jobs.json

system-images/android/sdk/build-libical
7

That's not needed, it will should created by build-cmake.

nicolasfella added a comment.Aug 3 2019, 11:04 PM

That should work. I don't have a strong opinion on it

apol added a comment.Aug 5 2019, 12:38 AM
In D22902#506234, @nicolasfella wrote:

That should work. I don't have a strong opinion on it

Then I recommend not adding a script unless there's weird/specific things that need doing.

nicolasfella abandoned this revision.Aug 5 2019, 10:22 AM

Revision Contents
Changeset List

Diff 62990

View Options

system-images/android/sdk/Dockerfile

Loading...
View Options

system-images/android/sdk/build-libical

Loading...