Differential D22892

Fix failing autotest grantleeheaderstyletest
ClosedPublic
Actions

Authored by gjditchfield on Aug 2 2019, 1:31 PM.

Details

Reviewers
dvratil
Commits
R94:7251f3cfad6c: Fix failing autotest grantleeheaderstyletest
Summary

defaultgrantleeheaderstyleplugin/theme/5.2/header.html originally produced
a chunk of HTML with two unclosed DIVs, and this test added two closing
tags in order to validate it. Revision a19720ae8e0a changed header.html
to have just one unclosed DIV.

This patch adapts the test to the change in header.html, and cleans up
some other minor bitrot.

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
gjditchfield created this revision.Aug 2 2019, 1:31 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptAug 2 2019, 1:31 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
gjditchfield requested review of this revision.Aug 2 2019, 1:31 PM
dvratil accepted this revision.Aug 5 2019, 11:41 AM
This revision is now accepted and ready to land.Aug 5 2019, 11:41 AM
Closed by commit R94:7251f3cfad6c: Fix failing autotest grantleeheaderstyletest (authored by gjditchfield, committed by dvratil). · Explain WhyAug 5 2019, 11:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 63110

View Options

messageviewer/src/header/autotests/data/allheaders.mbox.html

Loading...
View Options

messageviewer/src/header/autotests/data/empty.html

Loading...
View Options

messageviewer/src/header/autotests/data/vcard.html

Loading...
View Options

messageviewer/src/header/autotests/grantleeheaderstyletest.cpp

Loading...