Load animation speed from new global animation speed controller
ClosedPublic

Authored by davidedmundson on Aug 1 2019, 10:45 PM.

Details

Summary

It doesn't belong with advanced compositing settings as it's quite user
friendly, and we also want to adjust other animation speeds. May as well
do it together.

In the current form all compositing is still completely reinitiliased
like with the previous slider. Change notifications come in the form of
KConfigWatcher rather than our own bespoke update interface.

Test Plan

Moved new slider, minimised a window.
It still behaved as expected.

Diff Detail

Repository
R108 KWin
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 14667
Build 14685: arc lint + arc unit
davidedmundson created this revision.Aug 1 2019, 10:45 PM
Restricted Application added a project: KWin. · View Herald TranscriptAug 1 2019, 10:45 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Aug 1 2019, 10:45 PM
anthonyfieroni added inline comments.
options.cpp
1105

Where this come from?

broulik added inline comments.
options.cpp
1108

Shouldn't this be 1?

zzag added a subscriber: zzag.Aug 2 2019, 1:20 PM
zzag added inline comments.
options.cpp
1105

Window Rules KCM(kcmkwin/kwinrules) includes portions of KWin core.

1108

It shouldn't matter, but I wonder whether #endif above can be advanced a bit further.

Update config names

zzag added a comment.Sep 18 2019, 3:18 PM

@davidedmundson Is this 5.17 stuff?

At this point, no.

davidedmundson retitled this revision from WIP: Load animation speed from new global animation speed controller to Load animation speed from new global animation speed controller.Sep 19 2019, 1:08 PM
davidedmundson edited the summary of this revision. (Show Details)
zzag accepted this revision.Sep 19 2019, 3:52 PM
This revision is now accepted and ready to land.Sep 19 2019, 3:52 PM
zzag added inline comments.Sep 23 2019, 9:42 PM
composite.cpp
114

Oh, this one perhaps needs to be configChanged. We don't want to resume compositing if it's suspended at the moment.

Doesn't really make a difference, especially for the reason given.

void Compositor::configChanged()
{
    reinitialize();
    addRepaintFull();
}

If there is an inhibitor present, or compositing blocked for any other reason the start() call from reinitialize fails.

zzag added a comment.Sep 24 2019, 9:25 AM

X11Compositor overrides configChanged method.

So it does.

It would have still failed in start, but may as well make the change and have it fail earlier.

zzag added a comment.Sep 24 2019, 9:48 AM

Oh, yeah, I see. nvm

This revision was automatically updated to reflect the committed changes.