Rename "Plasma Theme" to "Plasma Style"
ClosedPublic

Authored by ngraham on Aug 1 2019, 6:52 PM.

Details

Summary

This implements one of the changes decided upon in T11314. The rationale is as follows:

We only use the word "Theme" for LNF settings in the appearance section. For everything else,
we use the word "style" if we have to use anything, preferring to not use any word at all. Since
the app settings use "Style", we should do the same thing for the contrasting Plasma setting.

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
plasma-theme-to-plasma-style (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14652
Build 14670: arc lint + arc unit
ngraham created this revision.Aug 1 2019, 6:52 PM
Restricted Application added projects: Plasma, Documentation. · View Herald TranscriptAug 1 2019, 6:52 PM
Restricted Application added subscribers: kde-doc-english, plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 1 2019, 6:52 PM
ngraham edited the summary of this revision. (Show Details)Aug 1 2019, 6:53 PM
GB_2 accepted this revision as: VDG, GB_2.Aug 1 2019, 7:51 PM
GB_2 added a subscriber: GB_2.

The KDE Store category name should probably be updated too.

This revision is now accepted and ready to land.Aug 1 2019, 7:51 PM
ngraham added a subscriber: leinir.Aug 1 2019, 7:53 PM
ngraham added inline comments.
kcms/desktoptheme/plasma-themes.knsrc
42

The KDE Store category name should probably be updated too.

You mean here? What does this actually do?

GB_2 added inline comments.Aug 1 2019, 7:54 PM
kcms/desktoptheme/plasma-themes.knsrc
42

I mean in the actual store online :-)

This revision was automatically updated to reflect the committed changes.
GB_2 added inline comments.Aug 3 2019, 11:34 AM
kcms/desktoptheme/kcm_desktoptheme.desktop
41

You forgot to change the name here too.

ngraham marked an inline comment as done.Aug 4 2019, 6:01 PM
ngraham added inline comments.
kcms/desktoptheme/kcm_desktoptheme.desktop
41