Rename "Look and Feel" KCM to "Global Theme"
ClosedPublic

Authored by ngraham on Aug 1 2019, 6:44 PM.

Details

Summary

This implements one of the changes decided upon in T11314. The rationale is as follows:

The old text ("Look and Feel") is a generic term and could be referring to any of the
other appearance settings. The new text "Global Theme" is more descriptive and accurate
and makes this KCM's relationship to everything else clear, especially once it's the only
KCM that uses the word "Theme" (see D22880).

Test Plan

Diff Detail

Repository
R119 Plasma Desktop
Branch
lnf-to-global (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14650
Build 14668: arc lint + arc unit
ngraham created this revision.Aug 1 2019, 6:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 1 2019, 6:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Aug 1 2019, 6:44 PM
ngraham edited the summary of this revision. (Show Details)Aug 1 2019, 6:58 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 62936.Aug 1 2019, 8:35 PM

Make "look and feel" a description rather than a product name

GB_2 accepted this revision as: VDG, GB_2.EditedAug 1 2019, 8:47 PM
GB_2 added a subscriber: GB_2.

We should probably also change the name in the KDE Store, Look and Feel Explorer and documentation.

kcms/lookandfeel/autotests/lookandfeel/metadata.desktop
2

"Test global theme package" or maybe "Test global look and feel"

kcms/lookandfeel/lnftool.cpp
42

Uppercase T in "tool" while at it :-)

This revision is now accepted and ready to land.Aug 1 2019, 8:47 PM

I'd like to get some Plasma opinions on this, since it is a fairly user-visible change.

ngraham edited the test plan for this revision. (Show Details)Aug 1 2019, 9:20 PM
ngraham updated this revision to Diff 62943.Aug 1 2019, 9:22 PM
ngraham marked 2 inline comments as done.

Address review comments

ngraham edited the test plan for this revision. (Show Details)Aug 2 2019, 6:24 PM
mart accepted this revision.Aug 9 2019, 2:04 PM
mart added a subscriber: mart.

fine for me if this and the store are changed simultaneously, and *no* internal name is changed anywhere (folder names, plugin names and so on)

GB_2 added inline comments.Aug 9 2019, 2:06 PM
kcms/lookandfeel/autotests/lookandfeel/metadata.desktop
2

Lowercase "global theme".

ngraham updated this revision to Diff 63413.Aug 9 2019, 2:09 PM
ngraham marked an inline comment as done.

Lowercase it in a Comment

Thanks @mart! Since this will land in Plasma 5.17, there's plenty of time to change it on store.kde.org. I'll coordinate.

This revision was automatically updated to reflect the committed changes.