Merge gtk320 and gtk318 into gtk3

Authored by cblack on Aug 1 2019, 3:27 PM.



GTK 3.20 and GTK 3.18 are now merged into a single GTK 3.0 directory. This will reduce work needed in the future for maintenance and updates.

In the past, GTK3 had an extremely unstable theming API, however, as GTK4 draws near, less focus has been given to breaking existing CSS with GTK3. This makes serving specific versions of GTK CSS redundant and doubles the work required to make changes for gains most users aren't likely to see.

Test Plan

See that themes work properly.

Diff Detail

R98 Breeze for Gtk
gtk-320-318-merge (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 14641
Build 14659: arc lint + arc unit
cblack created this revision.Aug 1 2019, 3:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptAug 1 2019, 3:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
cblack requested review of this revision.Aug 1 2019, 3:27 PM
ngraham added a subscriber: ngraham.Aug 1 2019, 3:36 PM

Not being an expert in this code or familiar with the history here, it would be helpful if you added a bit more information to the Description section. Specifically, why this split existed in the first place, the function it once served, why it's no longer necessary today, and any visual changes (if any) that result from this patch.

cblack edited the summary of this revision. (Show Details)Aug 1 2019, 8:11 PM
ngraham accepted this revision.Aug 1 2019, 10:53 PM


This revision is now accepted and ready to land.Aug 1 2019, 10:53 PM
ngraham retitled this revision from [Breeze-GTK] Merge gtk320 and gtk318 into gtk3 to Merge gtk320 and gtk318 into gtk3.Aug 2 2019, 4:48 PM
This revision was automatically updated to reflect the committed changes.