port to phonon 4.11, qt5, ecm
ClosedPublic

Authored by sitter on Jul 30 2019, 12:27 PM.

Details

Summary
  • move to featuresummary
    • this requires fairly awkward trickery for the plugins because of the way the plugin finder works (which is to say it doesn't as far as cmake is concerned). the plugins we want now have noop finder files (so cmake doesn't outright consider the packages not found) and then the variable set by the actual finder can be eval'd by featuresummary. this really should get refactored to "proper" cmake use of finder packages
  • install icons via ecm_install_icons
  • use imported targets where possible and appropriate
Test Plan

builds

Diff Detail

Repository
R488 Phonon: GStreamer backend
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Jul 30 2019, 12:27 PM
sitter created this revision.

@dvratil FWIW the plan is to break phonon's cmake compat so older backends no longer build with newer phonon. this allows us to get rid of all the cmake cruft upon which the backends implicitly relied. see ecm branch on phonon.git

I may be swayed to keep compat, but honestly I for one don't see the point.

dvratil accepted this revision.Aug 5 2019, 8:08 AM

I did not try to build it, but the changes look sensible to me. πŸ‘

This revision is now accepted and ready to land.Aug 5 2019, 8:08 AM
This revision was automatically updated to reflect the committed changes.