Make render positions an enum instead of string-based values
AbandonedPublic

Authored by kossebau on Jul 25 2016, 1:51 PM.

Details

Reviewers
nienhueser
rahn
shentey
Group Reviewers
Marble
Summary

Allows build-time check of values used and is faster at runtime, due to
comparing bits instead of strings (lists)

Diff Detail

Repository
R34 Marble
Branch
makeRenderPositionsAnEnum
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau updated this revision to Diff 5489.Jul 25 2016, 1:51 PM
kossebau retitled this revision from to Make render positions an enum instead of string-based values.
kossebau updated this object.
kossebau added reviewers: Marble, rahn, shentey, nienhueser.
nienhueser accepted this revision.Jul 25 2016, 7:04 PM
nienhueser edited edge metadata.

Looks great to me. @rahn any objections?

This revision is now accepted and ready to land.Jul 25 2016, 7:04 PM
kossebau abandoned this revision.Jan 29 2017, 9:01 PM

Does not apply any longer, also seems that using string-based position ids was a design decision which has not completely been dropped.