Differential D22760

[Notifications] Keep new delegate hidden until room has been cleared
ClosedPublic
Actions

Authored by broulik on Jul 26 2019, 9:22 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R120:f5515049b37f: [Notifications] Keep new delegate hidden until room has been cleared
Summary

When a new notification comes in, we first displace the existing ones to make room and then animate in the new one.
However, due to the PauseAnimation the item appears with its full opacity ontop of the existing notifications that move out of the way.
Add a PropertyAction to ensure the item has an opacity of zero initially.

Test Plan

5.16 branch

  • Added multiple notifications to the popup, had them nicely appear instead of awkwardly overlapping visually

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 26 2019, 9:22 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 26 2019, 9:22 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 26 2019, 9:22 AM
ngraham accepted this revision.Jul 26 2019, 1:27 PM
ngraham added a subscriber: ngraham.

Looks nicer when there's a notification flood.

This revision is now accepted and ready to land.Jul 26 2019, 1:27 PM
Closed by commit R120:f5515049b37f: [Notifications] Keep new delegate hidden until room has been cleared (authored by broulik). · Explain WhyJul 26 2019, 1:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 62587

View Options

applets/notifications/package/contents/ui/FullRepresentation.qml

Loading...