xcb: Fix setStrut() for High-DPI scaling
Needs ReviewPublic

Authored by volkov on Jul 25 2019, 11:35 AM.

Details

Reviewers
None
Group Reviewers
Frameworks
Summary

In addition to _NET_WM_STRUT setStrut() also sets _NET_WM_STRUT_PARTIAL,
which requires screen's geometry in device pixels.

Diff Detail

Repository
R278 KWindowSystem
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14405
Build 14423: arc lint + arc unit
volkov created this revision.Jul 25 2019, 11:35 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 25 2019, 11:35 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
volkov requested review of this revision.Jul 25 2019, 11:35 AM
apol added a subscriber: apol.Jul 25 2019, 12:45 PM
apol added inline comments.
src/platforms/xcb/kwindowsystem.cpp
75

I don't think that it makes sense to multiply topLeft by dpr, since dpr is local to the screen you're treating.

How have you tested this?

volkov added inline comments.Jul 25 2019, 1:02 PM
src/platforms/xcb/kwindowsystem.cpp
75

Only on a single screen. Thanks for notice.