Support displaying emoticons in connection name and SSID
AbandonedPublic

Authored by jgrulich on Jul 25 2019, 8:50 AM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

BUG: 408550

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14400
Build 14418: arc lint + arc unit
jgrulich created this revision.Jul 25 2019, 8:50 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 25 2019, 8:50 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Jul 25 2019, 8:50 AM
jgrulich retitled this revision from Support displaying emoticons in connection name and SSID BUG: 408550 to Support displaying emoticons in connection name and SSID.Jul 25 2019, 8:50 AM
jgrulich edited the summary of this revision. (Show Details)
jgrulich added a reviewer: Plasma.

-1 to dragging in KEmoticons for that.
Aren't they just unicode Emojis which we can render just fine elsewhere.

applet/contents/ui/DetailsText.qml
84

Since there are HTML tags already, it defaults to StyledText already, but it doesn't hurt to be explicit

106

Make sure the text is HTML-escaped

jgrulich abandoned this revision.Jul 25 2019, 11:22 AM

-1 to dragging in KEmoticons for that.
Aren't they just unicode Emojis which we can render just fine elsewhere.

You are right, I can display them just fine. I should have tried that before.