Use KRun::runApplication instead of KRun::runService
AbandonedPublic

Authored by nicolasfella on Jul 24 2019, 11:24 AM.

Details

Reviewers
aacid
Group Reviewers
Okular
Summary

KRun::runService is about to be deprecated. The difference is that runService waits for the application to register on DBus, wich seems irrelevant here

Diff Detail

Repository
R223 Okular
Branch
rs
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14365
Build 14383: arc lint + arc unit
nicolasfella created this revision.Jul 24 2019, 11:24 AM
Restricted Application added a project: Okular. · View Herald TranscriptJul 24 2019, 11:24 AM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 24 2019, 11:24 AM
nicolasfella edited the summary of this revision. (Show Details)Jul 24 2019, 11:24 AM
aacid added a subscriber: aacid.Jul 24 2019, 6:23 PM

In which KF5 version has runApplication been introduced?

Can you please use invent.k.o in the future?

aacid requested changes to this revision.Feb 21 2020, 6:54 PM

Please move as a Merge Request in https://invent.kde.org/kde/okular

We have pre-commit CI and lots of checks including clazy and clang-tidy there so it's a much better place for doing the review/approval/merge of the code.

This revision now requires changes to proceed.Feb 21 2020, 6:54 PM
nicolasfella abandoned this revision.Apr 14 2020, 4:28 PM