Differential D22709

Support passing target to ecm_add_app_icon.
AbandonedPublic
Actions

Authored by daandemeyer on Jul 24 2019, 7:30 AM.

Details

Reviewers
alexmerry
dschmidt
Summary

Same as https://phabricator.kde.org/D22698 for ecm_add_app_icon.

Test Plan

I don't have KDE setup on Windows or access to a Mac and I think this code is only fully exercised on those system. I confirmed it doesn't break anything on Linux by running kate's CMake configuration but that's only half of the work since most of the macro isn't used on Linux. If anyone could verify this patch works on Windows or Mac it would be much appreciated.

Diff Detail

Repository
R240 Extra CMake Modules
Lint
Lint Skipped
Unit
Unit Tests Skipped
daandemeyer created this revision.Jul 24 2019, 7:30 AM
Restricted Application added a project: Build System. · View Herald TranscriptJul 24 2019, 7:30 AM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
daandemeyer requested review of this revision.Jul 24 2019, 7:30 AM
krop added a subscriber: krop.Aug 14 2019, 1:40 PM

-1.

This shall be compliant with the minimum ECM version set in the project.

daandemeyer abandoned this revision.Aug 22 2019, 7:53 AM

KF6 is a long time out so I'm abandoning this.

Revision Contents
Changeset List

PathPackages
Mmodules/ECMAddAppIcon.cmake (27 lines)

Diff 62455

View Options

modules/ECMAddAppIcon.cmake

Loading...