Properly initialize oldStart and oldEnd in PreviewImageProvider::requestImage
ClosedPublic

Authored by arojas on Jul 23 2019, 11:10 PM.

Details

Summary

Otherwise they may not get assigned any value if the xft exclude range is (0,0), which will make them write random values to the xft exclude range later.

BUG: 409518

Test Plan

Open the fonts KCM a few times, check that no random font size interval is being excluded from antialiasing.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Jul 23 2019, 11:10 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 23 2019, 11:10 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
arojas requested review of this revision.Jul 23 2019, 11:10 PM

Just noticed this is fixed in master already, so this is for 5.16 only

bshah accepted this revision.Jul 24 2019, 12:14 AM

Nice work finding this bug!

This revision is now accepted and ready to land.Jul 24 2019, 12:14 AM
ngraham accepted this revision.Jul 24 2019, 1:57 AM
This revision was automatically updated to reflect the committed changes.