Rename the KCalCore namespace to KCalendarCore
ClosedPublic

Authored by vkrause on Jul 23 2019, 6:50 PM.

Details

Summary

As per discussion on kde-frameworks-devel. This is only the ABI-relevant
part so far, the API-relevant part in form of the include paths, as well
as documentation and various internal bits still need to be adjusted.

The ugly part here is the backward compatibility hack. An alias namespace
unfortunately isn't enough, it breaks with existing forward declarations.
We therefore need a way to rename the old KCalCore name in code that does
not include any of our headers too. All KDE PIM code builds unmodified
with this.

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Jul 23 2019, 6:50 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJul 23 2019, 6:50 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Jul 23 2019, 6:50 PM
dfaure accepted this revision.Jul 24 2019, 9:28 PM
dfaure added inline comments.
src/CMakeLists.txt
50

This could be INTERFACE rather than PUBLIC, we don't need this define when compiling KF5CalendarCore itself (assuming there's no KCalCore left in there).

This revision is now accepted and ready to land.Jul 24 2019, 9:28 PM
This revision was automatically updated to reflect the committed changes.

Not sure if this is the best spot to report it, but Neon dev/stable kdepim packages are currently broken because of this - I guess someone needs to trigger a rebuild/version bump of packages depending on kcalcore?

When trying to start kmail, I get:

kmail: symbol lookup error: /usr/lib/x86_64-linux-gnu/libKF5MessageComposer.so.5: undefined symbol: _ZN8KCalCore9Incidence16staticMetaObjectE

Wrong place indeed, we're not working on neon, you should contact the neon packagers.