Replace QString::null with QString
AbandonedPublic

Authored by aacid on Jul 23 2019, 3:01 PM.

Diff Detail

Repository
R249 KI18n
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14332
Build 14350: arc lint + arc unit
aacid created this revision.Jul 23 2019, 3:01 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 23 2019, 3:01 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Jul 23 2019, 3:01 PM
apol accepted this revision.Jul 23 2019, 9:21 PM
This revision is now accepted and ready to land.Jul 23 2019, 9:21 PM
aacid closed this revision.Jul 23 2019, 9:23 PM
nicolasfella reopened this revision.Jul 23 2019, 11:24 PM
nicolasfella added a subscriber: nicolasfella.

This breaks building Okular for me

[  0%] Automatic MOC for target urldetecttest
[  0%] Automatic MOC for target okular
[  0%] Automatic MOC for target okularcore
[  0%] Generating index.cache.bz2
[  0%] Automatic MOC for target okularkirigami
[  0%] Automatic MOC for target editdrawingtooldialogtest
[  0%] Generating okular.1
[  0%] Built target okularkirigami_autogen
[  1%] Automatic RCC for app.qrc
Scanning dependencies of target okularkirigami
[  1%] Built target editdrawingtooldialogtest_autogen
Scanning dependencies of target editdrawingtooldialogtest
[  1%] Building CXX object mobile/app/CMakeFiles/okularkirigami.dir/okularkirigami_autogen/mocs_compilation.cpp.o
[  1%] Building CXX object mobile/app/CMakeFiles/okularkirigami.dir/main.cpp.o
[  1%] Built target okular_autogen
[  1%] Built target urldetecttest_autogen
[  1%] Building CXX object mobile/app/CMakeFiles/okularkirigami.dir/okularkirigami_autogen/EWIEGA46WW/qrc_app.cpp.o
[  1%] Building CXX object conf/autotests/CMakeFiles/editdrawingtooldialogtest.dir/editdrawingtooldialogtest_autogen/mocs_compilation.cpp.o
Note: namesp. add : added namespace before processing              The Okular Handbook
Scanning dependencies of target okular
Note: namesp. add : added namespace before processing              Okular User's Manual
Note: Writing okular.1
Scanning dependencies of target urldetecttest
[  1%] Building CXX object shell/CMakeFiles/okular.dir/okular_autogen/mocs_compilation.cpp.o
[  1%] Built target doc-okular-1
[  2%] Building CXX object autotests/CMakeFiles/urldetecttest.dir/urldetecttest_autogen/mocs_compilation.cpp.o
[  2%] Building CXX object shell/CMakeFiles/okular.dir/main.cpp.o
[  2%] Building CXX object conf/autotests/CMakeFiles/editdrawingtooldialogtest.dir/editdrawingtooldialogtest.cpp.o
[  2%] Building CXX object autotests/CMakeFiles/urldetecttest.dir/urldetecttest.cpp.o
[  2%] Built target okularcore_autogen
[  2%] Building CXX object shell/CMakeFiles/okular.dir/okular_main.cpp.o
[  2%] Built target doc-index-cache-bz2
[  3%] Building CXX object conf/autotests/CMakeFiles/editdrawingtooldialogtest.dir/__/editdrawingtooldialog.cpp.o
[  4%] Generating settings_core.h, settings_core.cpp
[  5%] Generating qrc_builtin.cpp
[  5%] Generating ui_textdocumentsettings.h
CMake Error at /home/nico/kde/usr/lib64/cmake/KF5I18n/kf5i18nuic.cmake:39 (STRING):
  STRING sub-command REGEX, mode REPLACE: Unknown escape "\(" in
  replace-expression.


make[2]: *** [CMakeFiles/okularcore.dir/build.make:68: ui_textdocumentsettings.h] Error 1
make[1]: *** [CMakeFiles/Makefile2:136: CMakeFiles/okularcore.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[  6%] Building CXX object shell/CMakeFiles/okular.dir/shell.cpp.o
[  7%] Linking CXX executable okularkirigami
[  7%] Built target okularkirigami
[  7%] Building CXX object shell/CMakeFiles/okular.dir/shellutils.cpp.o
[  7%] Linking CXX executable editdrawingtooldialogtest
[  7%] Built target editdrawingtooldialogtest
[  7%] Linking CXX executable urldetecttest
[  7%] Built target urldetecttest
[  7%] Linking CXX executable okular
[  7%] Built target okular
make: *** [Makefile:141: all] Error 2
This revision is now accepted and ready to land.Jul 23 2019, 11:24 PM
nicolasfella requested changes to this revision.Jul 23 2019, 11:25 PM
This revision now requires changes to proceed.Jul 23 2019, 11:25 PM

I can see that several frameworks can't build anymore on build.kde.org after the change.

aacid abandoned this revision.Jul 24 2019, 8:16 AM

Fixed it manually, marking it as abandoned since i can't close any other way.

Sorry, should have tested this a bit more, yesterday it was late :/