[Klipper] Fix clipboard history management
Needs ReviewPublic

Authored by pdabrowski on Tue, Jul 23, 2:01 PM.

Details

Summary

Fixed clearing the clipboard when clearing history
(bug #409366 caused by 3bd6ac34ed74e3b86bfb6b29818b726baf505f20)

Properly synchronize clipboard content and history
(deleting last item in history didn't clear the clipboard).

Keep last image in history even if we are ignoring images, but without preview
(so that we can still clear history, and the tooltip says truth about clipboard content).

Fixed tray icon tooltip text.

Do not scale small images up in clipboard Plasmoid.

BUG: 409366

Test Plan

Spectacle -> [Copy to Clipboard]
Paste into Dolphin (clipboard content)

Deleting single items from clipboard

Clearing the entire history

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
pdabrowski created this revision.Tue, Jul 23, 2:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Jul 23, 2:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
pdabrowski requested review of this revision.Tue, Jul 23, 2:01 PM
pdabrowski updated this revision to Diff 62398.Tue, Jul 23, 2:16 PM
pdabrowski updated this revision to Diff 62410.Tue, Jul 23, 3:04 PM

new diff: much better patch

ngraham retitled this revision from [Plasma Workspace][Klipper] Fixed clipboard history clearing (#409366) to [Plasma Workspace][Klipper] Fixed clipboard history clearing.Tue, Jul 23, 5:26 PM
ngraham edited the summary of this revision. (Show Details)

Thanks for the patch!

A more descriptive Description section would be appreciated: you could explain what the issue is and how specifically this patch fixes it. In general that improves the likelihood of quick review. :)

ngraham retitled this revision from [Plasma Workspace][Klipper] Fixed clipboard history clearing to [Klipper] Fix clipboard history clearing.Tue, Jul 23, 5:29 PM
ngraham edited the summary of this revision. (Show Details)
pdabrowski edited the summary of this revision. (Show Details)Tue, Jul 23, 5:58 PM
davidedmundson accepted this revision.Tue, Jul 23, 6:07 PM
This revision is now accepted and ready to land.Tue, Jul 23, 6:07 PM
pdabrowski planned changes to this revision.Tue, Jul 23, 6:14 PM

Weak pointer might not work well for this after all.
I need to have a second look at this patch.

pdabrowski retitled this revision from [Klipper] Fix clipboard history clearing to [Klipper] Fix clipboard history management.
pdabrowski edited the summary of this revision. (Show Details)

new diff: proper fix for clipboard history management

This revision is now accepted and ready to land.Tue, Jul 23, 10:45 PM
pdabrowski requested review of this revision.Tue, Jul 23, 10:46 PM
pdabrowski updated this revision to Diff 63145.Mon, Aug 5, 8:19 PM
pdabrowski edited the summary of this revision. (Show Details)
pdabrowski edited the test plan for this revision. (Show Details)
This comment was removed by pdabrowski.
pdabrowski edited the summary of this revision. (Show Details)Mon, Aug 5, 8:23 PM
pdabrowski updated this revision to Diff 63147.Mon, Aug 5, 9:01 PM

New, much better solution.

pdabrowski edited the summary of this revision. (Show Details)Mon, Aug 5, 9:22 PM
pdabrowski edited the summary of this revision. (Show Details)Mon, Aug 5, 10:14 PM
pdabrowski edited the summary of this revision. (Show Details)