Differential D22664

Add more fallbacks to NameProperty
ClosedPublic
Actions

Authored by jbbgameich on Jul 22 2019, 8:55 PM.

Tags

None

Subscribers

None

Details

Reviewers

Commits

R732:42faff03555d: Add more fallbacks to NameProperty

Diff Detail

Repository

R732 KPeople VCard Support

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

jbbgameich requested review of this revision.Jul 22 2019, 8:55 PM

jbbgameich created this revision.

Harbormaster completed remote builds in B14301: Diff 62352.Jul 22 2019, 8:56 PM

jbbgameich added a reviewer: apol.Jul 22 2019, 8:56 PM

apol accepted this revision.Jul 22 2019, 10:20 PM

apol added inline comments.

src/kpeoplevcard.cpp
54	why `+ "" +`? How about `return i18nc("given-name family-name", "%1 %2, m_addressee.givenName(), m_addressee.familyName());`

This revision is now accepted and ready to land.Jul 22 2019, 10:20 PM

jbbgameich added inline comments.Jul 22 2019, 10:41 PM

src/kpeoplevcard.cpp
54	Sounds a lot better. I just forgot a space between the `" "` though initially.

jbbgameich added inline comments.Jul 22 2019, 10:59 PM

src/kpeoplevcard.cpp
54	kpeoplevcard previously didn't depend on i18n, is adding a new dependency fine?

use i18nc as requested in the comments

Harbormaster completed remote builds in B14305: Diff 62361.Jul 22 2019, 11:02 PM

Good stuff :)

Closed by commit R732:42faff03555d: Add more fallbacks to NameProperty (authored by jbbgameich). · Explain WhyJul 23 2019, 3:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			autotests/CMakeLists.txt (2 lines)
M			src/CMakeLists.txt (2 lines)
M			src/kpeoplevcard.cpp (13 lines)

Diff 62409

CMakeLists.txt

Loading...

autotests/CMakeLists.txt

Loading...

src/CMakeLists.txt

Loading...

src/kpeoplevcard.cpp

Loading...