Differential D22660

Fixed crash when filtering class list
ClosedPublic
Actions

Authored by mdlubakowski on Jul 22 2019, 6:25 PM.

Details

Reviewers
None
Group Reviewers
KDevelop
Commits
R32:5bff5d65a023: Fixed crash when filtering class list
Summary

Related: BUG 406931
Issue: When you select an inner node (method or member) in Classes panel, then type something in search bar that filters that node out, Kdevelop crashes.
It seems that when nodes get filtered, at some point currentIndex of QTreeView points to deleted node, which causes segfault in ClassModel::hasChildren.
Manually invalidating currentIndex before filtering seems to have fixed the issue, I would appreciate if somebody else tested that too.

Diff Detail

Repository
R32 KDevelop
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14294
Build 14312: arc lint + arc unit
mdlubakowski created this revision.Jul 22 2019, 6:25 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptJul 22 2019, 6:25 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
mdlubakowski requested review of this revision.Jul 22 2019, 6:25 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 20 2019, 4:11 AM
Closed by commit R32:5bff5d65a023: Fixed crash when filtering class list (authored by mdlubakowski, committed by mwolff). · Explain Why
This revision was automatically updated to reflect the committed changes.
mwolff added a subscriber: mwolff.Sep 20 2019, 4:11 AM

thanks, applied to 5.4

Revision Contents
Changeset List

Diff 62339

View Options

plugins/classbrowser/classwidget.cpp

Loading...