Show the tracking box on the inital focusing frame
ClosedPublic

Authored by wreissenberger on Jul 22 2019, 2:55 PM.

Details

Summary

In the initial focusing frame, the tracking box is currently placed in the top left corner instead of the star selected for focusing. With this fix, the green tracking box is placed around the star selected for focusing.

Test Plan

Start an autofocus session and check, where the tracking box is placed on the initial frame.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.Jul 22 2019, 2:55 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 22 2019, 2:55 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Jul 22 2019, 2:55 PM

How do you reproduce that? I see the box in the image center if no star is selected, and I see it around the star if there is a star selected.

Select "Sub Frame" and "Auto Select Star". Set "Box Size" to a small value, e.g. 128. Then start "Autofocus". Without this fix, the green box should be in the top left corner of the full frame image. With the fix, it is around the focus star.

You're absolutely right! I guess I didn't notice much because on the next frame, it's in the right place. Thanks!

mutlaqja accepted this revision.Jul 22 2019, 4:20 PM
This revision is now accepted and ready to land.Jul 22 2019, 4:20 PM
This revision was automatically updated to reflect the committed changes.