Add new patron to kde.org footer
AbandonedPublic

Authored by ognarb on Jul 22 2019, 12:54 PM.

Details

Reviewers
None
Group Reviewers
Websites
KDE e.V.
Test Plan

How it looks with multiple resolutions:

Diff Detail

Branch
/trunk/www/sites/www
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14260
Build 14278: arc lint + arc unit
ognarb requested review of this revision.Jul 22 2019, 12:54 PM
ognarb created this revision.
ognarb edited the test plan for this revision. (Show Details)Jul 22 2019, 12:56 PM
ognarb added a reviewer: Websites.
ognarb added a subscriber: kde-www.
ognarb updated this revision to Diff 62287.Jul 22 2019, 1:04 PM

Add alt information to image, because a11y

ognarb updated this revision to Diff 62292.Jul 22 2019, 1:19 PM

Fix typo

aacid added a subscriber: aacid.Jul 22 2019, 3:04 PM

it's kind of weird you added alt only for one of them, i'd say don't add alt or add alt for all the existing patrons

ognarb planned changes to this revision.Jul 22 2019, 3:15 PM

it's kind of weird you added alt only for one of them, i'd say don't add alt or add alt for all the existing patrons

I didn't want to add unrelated change.

ognarb updated this revision to Diff 62311.Jul 22 2019, 3:21 PM

Add alt to all KDE Patrons image

lydia added a subscriber: lydia.Jul 22 2019, 4:13 PM

๐Ÿ‘
Thanks!

ognarb abandoned this revision.EditedJul 22 2019, 4:27 PM

I committed this patch with 1547284. It can be that the image looks smaller than the others, this is because of the cache. If this is a problem, I can manually force refresh (by adding ?ver=1 in the CSS request).