Deprecate suggestName
ClosedPublic
Actions

Authored by nicolasfella on Jul 22 2019, 9:35 AM.

Details

Reviewers

dfaure

Commits

R241:4cdf7f01c191: Deprecate suggestName

Summary

KCoreAddons now has a drop-in replacement. Deprecate this so it can be removed in KF6

Test Plan

Buils. Deprecation warnings are thrown due to internal use that will be ported in a future patch

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Jul 22 2019, 9:35 AM

src/core/global.h
144	I like it when we say when something got deprecated, like this @deprecated since 5.61, use KFileUtils::suggestName() from KCoreAddons

This revision is now accepted and ready to land.Jul 22 2019, 8:11 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/core/global.h (5 lines)
M			src/core/global.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62271	928352e		Jul 22 2019, 9:35 AM	★	★
Diff 2	62325	928352e	- Include deprecated since	Jul 22 2019, 4:55 PM	★	★
Diff 3	62354	6501067	R241:4cdf7f01c1919da29766e1f68d5b78cbf727c593	Jul 22 2019, 9:03 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
4c0e05063e1e	06d1652b8ce8	b375418d3fd6	Nicolas Fella	Don't build with KIOCORE_NO_DEPRECATED	Jul 22 2019, 4:54 PM
b375418d3fd6	36957be6d0ed	0fd8ef385ec1	Nicolas Fella	Include deprecated since	Jul 22 2019, 4:46 PM
0fd8ef385ec1	94af6ec5da24	928352eaca18	Nicolas Fella	Deprecate suggestName (Show More…)	Jul 21 2019, 6:59 PM