Details
Details
- Reviewers
stikonas cjlcarvalho - Commits
- R16:7af8045f3263: Add unit test for Device
Diff Detail
Diff Detail
- Repository
- R16 KPMCore
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
test/testdevice.cpp | ||
---|---|---|
81 | I think I have some USB devices that actually return empty string... |
test/testdevice.cpp | ||
---|---|---|
81 | You need to check if QList is empty before calling first() |
test/testdevice.cpp | ||
---|---|---|
81 | Why don't you check if any device from the list has the empty name instead of checking only the first one? |
Comment Actions
I guesss it's alright to go in for now.
Although, it's a bit ugly that we are relying on devices present on tester's system... But anything else would be much harder.