i18n: Add context @title:window to window titles
ClosedPublic
Actions

Authored by aspotashev on Jul 21 2019, 2:07 AM.

Details

Reviewers

aheinecke
dvratil

Commits

Test Plan

none

Repository

R168 Kleopatra

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

aspotashev requested review of this revision.Jul 21 2019, 2:07 AM

Since you are changing the strings, I suggest changing them to bein line with the HIG:
https://hig.kde.org/style/writing/capitalization.html

src/commands/exportpaperkeycommand.cpp
114	"Print Secret Map"
src/crypto/gui/signencryptemailconflictdialog.cpp
417	"for"
542	"for"
src/dialogs/exportdialog.cpp
172	no "..."
src/dialogs/subkeyswidget.cpp
173	"Details"
src/dialogs/updatenotification.cpp
214	"Update Available" (no exclamation mark)
src/view/pgpcardwidget.cpp
278	"Keys"

done

LGTM

This revision is now accepted and ready to land.Jul 23 2019, 9:17 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/commands/clearcrlcachecommand.cpp (4 lines)
M			src/commands/dumpcertificatecommand.cpp (2 lines)
M			src/commands/dumpcrlcachecommand.cpp (2 lines)
M			src/commands/exportpaperkeycommand.cpp (2 lines)
M			src/commands/gnupgprocesscommand.cpp (2 lines)
M			src/commands/learncardkeyscommand.cpp (4 lines)
M			src/commands/setinitialpincommand.cpp (2 lines)
M			src/conf/configuredialog.cpp (2 lines)
M			src/crypto/decryptverifyemailcontroller.cpp (2 lines)
M			src/crypto/decryptverifyfilescontroller.cpp (2 lines)
M			src/crypto/gui/decryptverifyfilesdialog.cpp (4 lines)
M			src/crypto/gui/encryptemailwizard.cpp (2 lines)
M			src/crypto/gui/signemailwizard.cpp (2 lines)
M			src/crypto/gui/signencryptemailconflictdialog.cpp (4 lines)
M			src/crypto/gui/signingcertificateselectiondialog.cpp (2 lines)
M			src/dialogs/addemaildialog.cpp (2 lines)
M			src/dialogs/certificatedetailswidget.cpp (2 lines)
M			src/dialogs/certificateselectiondialog.cpp (2 lines)
M			src/dialogs/certifycertificatedialog.cpp (2 lines)
M			src/dialogs/expirydialog.cpp (2 lines)
M			src/dialogs/exportdialog.cpp (2 lines)
M			src/dialogs/ownertrustdialog.cpp (2 lines)
M			src/dialogs/subkeyswidget.cpp (2 lines)
M			src/dialogs/trustchainwidget.cpp (2 lines)
M			src/dialogs/updatenotification.cpp (2 lines)
M			src/dialogs/weboftrustdialog.cpp (2 lines)
M			src/kwatchgnupg/kwatchgnupgconfig.cpp (2 lines)
M			src/newcertificatewizard/newcertificatewizard.cpp (2 lines)
M			src/view/pgpcardwidget.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62162	22a29f5		Jul 21 2019, 2:07 AM	★	★
Diff 2	62235	22a29f5	- i18n: Fix window titles in accordance with HIG	Jul 21 2019, 8:28 PM	★	★
Diff 3	62412	22a29f5	R168:e8ee6a35065e2b4739bdf50643d830edfb889be5	Jul 23 2019, 3:27 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
18a9212cb6c2	3b2a5fbfc493	8c114ba8cf98	Alexander Potashev	i18n: Fix window titles in accordance with HIG	Jul 21 2019, 8:27 PM
8c114ba8cf98	3eff3b4a5ee5	22a29f59c6c3	Alexander Potashev	i18n: Add context @title:window to window titles (Show More…)	Jul 21 2019, 1:56 AM