Show previous color in color selector
ClosedPublic

Authored by akapustin on Jul 22 2016, 11:10 AM.

Details

Reviewers
dkazakov
timotheegiet
Group Reviewers
Krita
Test Plan

When picking a color in color selector, the colour previously used displayed next to the box showing the current color being chosen.
Example: https://www.youtube.com/watch?v=Z4YwGeaEJCw&feature=youtu.be
Bug: https://bugs.kde.org/show_bug.cgi?id=358673

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
akapustin updated this revision to Diff 5427.Jul 22 2016, 11:10 AM
akapustin retitled this revision from to Show previous color in color selector.
akapustin updated this object.
akapustin edited the test plan for this revision. (Show Details)
akapustin added a reviewer: dkazakov.
akapustin set the repository for this revision to R37 Krita.
akapustin added a project: Krita.
Restricted Application added a subscriber: woltherav. · View Herald TranscriptJul 22 2016, 11:10 AM
akapustin updated this revision to Diff 5429.Jul 22 2016, 11:19 AM

Code style fixes

akapustin updated this revision to Diff 5430.Jul 22 2016, 11:23 AM

Code style fixes: removing empty lines

akapustin updated this revision to Diff 5432.Jul 22 2016, 11:27 AM

Code style fix

akapustin updated this revision to Diff 5433.Jul 22 2016, 12:12 PM

Fix bad frame update and minor refactoring

akapustin updated this revision to Diff 5435.Jul 22 2016, 12:16 PM

Minor code style fix again

dkazakov requested changes to this revision.Jul 23 2016, 9:02 AM
dkazakov edited edge metadata.

The patch works weirdly :( See the video attached.

On the canvas I paint the color that I expect to see as the "previous color" patch in the color selector, but I see the one-but-last-but-last color instead. The other problem is that the "previous color patch" changes when I release the mouse. That is really distracting. The patch should change only when the user starts a new drag.

Otherwise, visually, the popup patches look nice :)

This revision now requires changes to proceed.Jul 23 2016, 9:02 AM
akapustin updated this revision to Diff 5458.Jul 23 2016, 1:19 PM
akapustin edited edge metadata.

Fix pre-pre-last color bug.

akapustin updated this revision to Diff 5460.Jul 23 2016, 1:45 PM
akapustin updated this object.
akapustin edited edge metadata.
akapustin updated this object.

Fix code-style bug

Looking at the last video example you sent, it still is not exactly that.

I think the preview should keep the last used color, so must not change until another color is used on the canvas (and not change all the time like it does now).

After discussion on irc, here's what we agreed on:
-two small rectangles, one with last used color (pulled from the last used colors list we already have), the other with last selected color (like it does now). This should be good for all the use cases.

akapustin updated this revision to Diff 5472.Jul 23 2016, 7:58 PM

Add second rect with last-used color

akapustin edited the test plan for this revision. (Show Details)Jul 23 2016, 8:19 PM
timotheegiet accepted this revision.Jul 23 2016, 9:03 PM
timotheegiet added a reviewer: timotheegiet.

Looks good, I'll push it to master. Thank you!

dkazakov accepted this revision.Jul 23 2016, 9:19 PM
dkazakov edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2016, 9:19 PM
This comment was removed by dkazakov.
dkazakov closed this revision.Aug 17 2016, 7:04 AM