Differential D22596

[MPRIS Data Engine] Ignore non-standards compliant players
ClosedPublic
Actions

Authored by broulik on Jul 20 2019, 8:20 PM.

Details

Reviewers
fvogt
Group Reviewers
Plasma
Commits
R120:8eec2cfd36c4: [MPRIS Data Engine] Ignore non-standards compliant players
Summary

Properties like Identity, SupportedUriSchemes, SupportedMimeTypes are mandatory. Ignore the player if it's clearly violating the spec.

Test Plan

Chrome's own unfinished mpris implementation no longer steals the show from p-b-i
Successfully tested with:

  • VLC
  • plasma-browser-integration
  • Spotify snap
  • Cantata
  • Juk
  • Clementine
  • Rhythmbox
  • Dragon Player

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jul 20 2019, 8:20 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 20 2019, 8:20 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jul 20 2019, 8:20 PM
broulik updated this revision to Diff 62151.Jul 20 2019, 9:01 PM
  • Ensure we always disconnect the initial fetch finished signal
fvogt accepted this revision.Aug 7 2019, 9:35 AM
fvogt added a subscriber: fvogt.

Code looks good, if you tested successfully with vlc this can IMO go in

This revision is now accepted and ready to land.Aug 7 2019, 9:35 AM
broulik edited the test plan for this revision. (Show Details)Aug 7 2019, 9:41 AM
Closed by commit R120:8eec2cfd36c4: [MPRIS Data Engine] Ignore non-standards compliant players (authored by broulik). · Explain WhyAug 7 2019, 9:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdataengines/mpris2/mpris2engine.cpp (19 lines)

Diff 63258

View Options

dataengines/mpris2/mpris2engine.cpp

Loading...