Compile helper into standalone application
AbandonedPublic
Actions

Authored by shubham on Jul 20 2019, 6:48 PM.

Details

Reviewers

stikonas
cjlcarvalho

Summary

Depends upon D22438

Repository

R16 KPMCore

Branch

main

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14185
Build 14203: arc lint + arc unit

shubham requested review of this revision.Jul 20 2019, 6:48 PM

shubham created this revision.

Diff relative to Polkit backend patch

shubham edited the test plan for this revision. (Show Details)

stikonas added inline comments.

src/util/externalcommandhelper.cpp
55	I think it would be simpler to just rename helperMain main() and get rid of the macro

This revision is now accepted and ready to land.Jul 21 2019, 9:45 AM

src/util/externalcommandhelper.cpp
55	I find using macro much neat then placing main() as a member function.(Even though they both do the same thing). Also doing so, undefined reference to main() is seen.

Merged this with the main patch ie. authorization backend

			Path	Packages
M			src/util/externalcommand_polkitbackend.h (1 line)
M			src/util/externalcommand_polkitbackend.cpp (1 line)
M			src/util/externalcommandhelper.h (2 lines)
M			src/util/externalcommandhelper.cpp (38 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	62140	6ea88cc		Jul 20 2019, 6:48 PM	★	★
Diff 2	62141	386013b	Diff relative to Polkit backend patch	Jul 20 2019, 6:49 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7e43fff60e2c	fa400118a63e	386013bf8f09	Shubham Jangra	Compile helper into standalone application (Show More…)	Jul 20 2019, 5:47 PM

Status	Author	Revision
Closed	shubham	D22321 Add unit test for Polkit backend
Abandoned	shubham	D22593 Compile helper into standalone application
Closed	shubham	D22438 Authorize using Polkit backend and compile Helper as standalone application