Autofocus disturbing meridian flip corrected
ClosedPublic

Authored by wreissenberger on Jul 20 2019, 1:54 PM.

Details

Summary

This patch corrects a bug in the communication between the Focus module and the Capture module. If the Capture module requests the meridian flip to wait until a capture is completed AND after this capture a re-focus is triggered, all further state changes of the Focus module are ignored.

Test Plan

Place the mount close before the meridian and create a capture set that requests a re-focus every minute. When passing the meridian, the mount should execute the meridian flip as soon as capturing and re-focusing is completed.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wreissenberger created this revision.Jul 20 2019, 1:54 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 20 2019, 1:54 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
wreissenberger requested review of this revision.Jul 20 2019, 1:54 PM
wreissenberger added inline comments.Jul 20 2019, 1:58 PM
kstars/ekos/capture/capture.cpp
3086

This seems to be a relict that does not make sense any more. On the other side, it prevents during the meridian flip that state updates of the focuser are processed.

wreissenberger edited the summary of this revision. (Show Details)Jul 20 2019, 4:12 PM
mutlaqja accepted this revision.Jul 23 2019, 5:50 PM
mutlaqja added inline comments.
kstars/ekos/capture/capture.cpp
3086

Ok, now that meridian flip is handled elsewhere I guess it is no longer needed. But focus update during a meridian flip have had some negative effects.

This revision is now accepted and ready to land.Jul 23 2019, 5:50 PM
wreissenberger added inline comments.Jul 23 2019, 7:39 PM
kstars/ekos/capture/capture.cpp
3086

Yes, I know. But meanwhile this methods holds only status update functionality. So I think it‘s better to execute it no matter what happens with the meridian flip.

This revision was automatically updated to reflect the committed changes.