[ksmserver] Use the new logout greeter binary to show the shutdown dialog
ClosedPublic

Authored by graesslin on Jul 22 2016, 9:29 AM.

Details

Summary

Ksmerver now starts the logout greeter binary instead of creating
the KSMShutdownDlg. The complete interaction to logout is now performed
in an async, non-blocking way.

Test Plan

Successfully cancelled logout and performed logout and shutdown

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 5416.Jul 22 2016, 9:29 AM
graesslin retitled this revision from to [ksmserver] Use the new logout greeter binary to show the shutdown dialog.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 22 2016, 9:29 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin updated this revision to Diff 5418.Jul 22 2016, 9:43 AM

Remove including shutdowndlg.cpp in ksmserver and drop the existing test app

davidedmundson accepted this revision.Jul 22 2016, 2:49 PM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
ksmserver/shutdown.cpp
187

leaks (sort of).

multiple logouts and cancels will result in lots of QProcess objects building up.

add a deleteLater in the finished slot

This revision is now accepted and ready to land.Jul 22 2016, 2:49 PM
graesslin marked an inline comment as done.Aug 4 2016, 10:51 AM
This revision was automatically updated to reflect the committed changes.