Differential D22556

Headers of parent class GeneralTest and child class HypothesisTest
ClosedPublic
Actions

Authored by devanshuagarwal on Jul 19 2019, 11:21 AM.

Details

Reviewers
sgerlach
asemke
Summary

Created base class GeneralTest for src/backend/generalTest/HypothesisTest. Since I have not changed much of the implementation of any function here so I have not uploaded source (.cpp) files.

Diff Detail

Repository
R262 LabPlot
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptJul 19 2019, 11:21 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
devanshuagarwal requested review of this revision.Jul 19 2019, 11:21 AM
sgerlach added a comment.Jul 19 2019, 7:40 PM

looks good so far.

GeneralTest.h
112

please use a global constant instead of 10. That makes it easier to extend it when needed.

devanshuagarwal marked an inline comment as done.Jul 20 2019, 10:52 AM
sgerlach accepted this revision.Jul 20 2019, 11:21 AM
This revision is now accepted and ready to land.Jul 20 2019, 11:21 AM
sgerlach closed this revision.Jul 20 2019, 11:21 AM

Revision Contents
Changeset List

PathPackages
AMGeneralTest.h (135 lines)
AMHypothesisTest.h (100 lines)

Diff 62052

View Options

GeneralTest.h

Loading...
View Options

HypothesisTest.h

Loading...