[KCM] Slightly improve tab bar's integration with frame
ClosedPublic

Authored by ngraham on Jul 18 2019, 5:34 PM.

Details

Summary

We don't yet have a real QML tab widget (https://bugs.kde.org/show_bug.cgi?id=394296)
so we have to manufacture our own by combining a TabBar with a frame in which the
content sits.

This patch slightly improves the look and feel of our manufactured tab widget
by moving the tab portion down a bit so it overlaps the frame, which does a
better job of mimiching the QWidgets version. It's not perfect, but it's at
least no worse with all the themes I tried, and for some it looks better.

Test Plan

Breeze, before:

Breeze after:

Oxygen, before:

Oxygen, after:

MSWindows, before:

MSWindows, after:

Fusion, before:

Fusion, after:

QtCurve, before:

QtCurve: after:

It's not always perfect, but for some it's better IMO, and it's at least not worse for any.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jul 18 2019, 5:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 18 2019, 5:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jul 18 2019, 5:34 PM
ngraham edited the test plan for this revision. (Show Details)Jul 18 2019, 5:37 PM
filipf accepted this revision.Mon, Jul 29, 10:46 PM
filipf added a subscriber: filipf.

Looks better. I would also add the bug no. to the comment so all instances of workarounds can be easily grepped when the bug is closed.

This revision is now accepted and ready to land.Mon, Jul 29, 10:46 PM
ngraham retitled this revision from [KCM] Slightly imptove tab bar's integration with frame to [KCM] Slightly improve tab bar's integration with frame.Thu, Aug 1, 12:59 AM

It's already in a comment above. :)

This revision was automatically updated to reflect the committed changes.