Differential D22530

Copy kioslave into KDE Connect app package
AbandonedPublic
Actions

Authored by Inoki on Jul 18 2019, 12:22 PM.

Details

Reviewers
None
Group Reviewers
Craft
Summary

kioslave is widely used by kf components, including transferring icon of notification in knotification.

This patch will copy it into MacOS folder so that its dependencies can be fixed by Craft.

Replace by: D22558

Diff Detail

Repository
R877 Craft Blueprints for KDE
Lint
Lint Skipped
Unit
Unit Tests Skipped
Inoki requested review of this revision.Jul 18 2019, 12:22 PM
Inoki created this revision.
vonreth added a subscriber: vonreth.Jul 18 2019, 12:48 PM

Could you think ab out a more general solution? Maybe move it to the macdmgpackager?
In order to work this needs to be done for all packages, not only kde-connect.

Inoki added a comment.Jul 18 2019, 12:50 PM
In D22530#497350, @vonreth wrote:

Could you think ab out a more general solution? Maybe move it to the macdmgpackager?
In order to work this needs to be done for all packages, not only kde-connect.

It's possible. But should we assume all the applications in Craft need it on macOS?

vonreth added a comment.Jul 18 2019, 12:51 PM

I think that we can asume that we want to use it if its not blacklisted and thus exists in the archiveDir

Inoki edited the summary of this revision. (Show Details)Jul 19 2019, 12:02 PM
Inoki edited the summary of this revision. (Show Details)
Inoki edited the summary of this revision. (Show Details)
vonreth added a comment.Jul 19 2019, 12:36 PM

I think this one can be closed now?

Inoki abandoned this revision.Jul 20 2019, 10:11 AM

Revision Contents
Changeset List

Diff 61975

View Options

extragear/kdeconnect-kde/kdeconnect-kde.py

Loading...