Do not display a buggy filesize for non local files
ClosedPublic

Authored by meven on Jul 18 2019, 11:35 AM.

Details

Summary

When displaying a virtual folder or remote drive the folder size in the information panel is wrong.
The subDirectoriesCount function supports only local files.
It creates a bug where when a url such as recentdocuments:/ is displayed in dolphin, the count reflected in the size field is in fact the count of its path meaning the number of files in the root folder /.

Test Plan

Manual

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Jul 18 2019, 11:35 AM
Restricted Application added a project: Baloo. · View Herald TranscriptJul 18 2019, 11:35 AM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
meven requested review of this revision.Jul 18 2019, 11:35 AM
meven edited the summary of this revision. (Show Details)Jul 22 2019, 1:58 PM
meven edited the summary of this revision. (Show Details)
meven edited the summary of this revision. (Show Details)
elvisangelaccio accepted this revision.Jul 28 2019, 2:35 PM

LGTM. Feel free to push on 19.08.

This revision is now accepted and ready to land.Jul 28 2019, 2:35 PM
This revision was automatically updated to reflect the committed changes.