There are some deprecated methods in the code:
Details
- Reviewers
ngraham - Group Reviewers
Gwenview - Commits
- R260:90f081d22747: Replace some obsolete methods with non-obsolete ones
- Run Gwenview, select an image.
- Use Edit -> Crop to ensure that cropping is working as expected.
- Press F11 to go to the full screen mode. The top panel should appear as expected.
Diff Detail
- Repository
- R260 Gwenview
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
I vote against bumping Qt to 5.10 just because of a single obsolete method. Qt 5.9 is a LTS release, which is supported until May 2020. E.g. I'm using openSUSE Leap 15.1, which uses 5.9.7 . Also, QImage::sizeInBytes() is recommend for images bigger 2GiB, but I never had success to open images that big with Gwenview.
lib/crop/croptool.cpp | ||
---|---|---|
274–275 | Add const here | |
lib/imagescaler.cpp | ||
134 | Wrap d->mRegion in qAsConst(d->mRegion) |
lib/crop/cropwidget.cpp | ||
---|---|---|
202–205 | Might be better to use QGuiApplication::screenAt() and get the screen where the window is open, rather than assuming it's open on the primary screen (also, the concept of the primary screen does not exist on Wayland; not sure what QGuiApplication::primaryScreen() will return there) | |
lib/fullscreenbar.cpp | ||
84–88 | ditto |
Thanks in advance for your answer.
lib/crop/cropwidget.cpp | ||
---|---|---|
202–205 | This will introduce the dependency on Qt 5.10: https://doc.qt.io/qt-5/qguiapplication.html#screenAt How should I proceed? | |
lib/fullscreenbar.cpp | ||
84–88 | Same here. |
Darn. Don't port those, then, and instead just add a TODO that says what we should do when we're going to bump the dep to a newer Qt version.