Differential D22526

QStringLiteral("") -> QString
ClosedPublic
Actions

Authored by aacid on Jul 18 2019, 10:15 AM.

Details

Reviewers
vkrause
Commits
R849:928266fa84ff: QStringLiteral("") -> QString
Summary

They are not exactly the same but in this case it's only used to be added to a path so it is the same

Diff Detail

Repository
R849 User Feedback Collection Framework
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14080
Build 14098: arc lint + arc unit
aacid requested review of this revision.Jul 18 2019, 10:15 AM
aacid created this revision.
broulik added a subscriber: broulik.Jul 18 2019, 10:26 AM

QString() is empty and null whereas QStringLiteral("") is empty but not null

aacid added a comment.Jul 18 2019, 10:38 AM

I know, did you read the summary?

broulik added a comment.Jul 18 2019, 10:39 AM

I missed the "not" there, don't mind me, just a passerby :)

vkrause accepted this revision.Jul 18 2019, 10:44 AM
This revision is now accepted and ready to land.Jul 18 2019, 10:44 AM
aacid closed this revision.Jul 18 2019, 9:46 PM

Revision Contents
Changeset List

Diff 61967

View Options

src/console/jobs/securityscanjob.cpp

Loading...