Differential D22520

Remove Growl support
ClosedPublic
Actions

Authored by nicolasfella on Jul 17 2019, 10:28 PM.

Details

Reviewers
broulik
Group Reviewers
Frameworks
Commits
R289:e2eed147c53c: Remove Growl support
Summary

We're about to get proper backends for Windows (D21661) and macOS (D22365). Judging by the code and comments this backend was never properly implemented anyway and will be dead code

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jul 17 2019, 10:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 17 2019, 10:28 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 17 2019, 10:28 PM
nicolasfella updated this revision to Diff 61942.Jul 17 2019, 10:29 PM
  • Remove unneeded include
nicolasfella edited the summary of this revision. (Show Details)Jul 17 2019, 10:31 PM
broulik accepted this revision.Jul 18 2019, 7:14 AM

(Once the replacement backends are actually in)

src/notifybypopupgrowl.cpp
27

lol

This revision is now accepted and ready to land.Jul 18 2019, 7:14 AM
Closed by commit R289:e2eed147c53c: Remove Growl support (authored by nicolasfella). · Explain WhyOct 11 2019, 9:09 AM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (1 line)
Msrc/notifybypopup.cpp (40 lines)

Diff 67687

View Options

src/CMakeLists.txt

Loading...
View Options

src/notifybypopup.cpp

Loading...