Differential D22520

Remove Growl support
ClosedPublic
Actions

Authored by nicolasfella on Jul 17 2019, 10:28 PM.

Details

Reviewers

broulik

Group Reviewers

Frameworks

Commits

R289:e2eed147c53c: Remove Growl support

Summary

We're about to get proper backends for Windows (D21661) and macOS (D22365). Judging by the code and comments this backend was never properly implemented anyway and will be dead code

Diff Detail

Repository

R289 KNotifications

Branch

growl

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 14063
Build 14081: arc lint + arc unit

nicolasfella created this revision.Jul 17 2019, 10:28 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJul 17 2019, 10:28 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Jul 17 2019, 10:28 PM

Harbormaster completed remote builds in B14063: Diff 61941.Jul 17 2019, 10:28 PM

Remove unneeded include

Harbormaster completed remote builds in B14064: Diff 61942.Jul 17 2019, 10:29 PM

nicolasfella edited the summary of this revision. (Show Details)Jul 17 2019, 10:31 PM

(Once the replacement backends are actually in)

src/notifybypopupgrowl.cpp
27	lol

This revision is now accepted and ready to land.Jul 18 2019, 7:14 AM

Closed by commit R289:e2eed147c53c: Remove Growl support (authored by nicolasfella). · Explain WhyOct 11 2019, 9:09 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (1 line)
M		src/knotification.cpp (1 line)
M		src/notifybypopup.cpp (40 lines)
D	M	src/notifybypopupgrowl.h (48 lines)
D	M	src/notifybypopupgrowl.cpp (66 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	61941	82207f9		Jul 17 2019, 10:28 PM	★	★
Diff 2	61942	82207f9	- Remove unneeded include	Jul 17 2019, 10:29 PM	★	★
Diff 3	67687	58caf6a	R289:e2eed147c53cc2a3134e444208057e0804403a5b	Oct 11 2019, 9:08 AM	★	★