Remove Growl support
AcceptedPublic

Authored by nicolasfella on Jul 17 2019, 10:28 PM.

Details

Reviewers
broulik
Group Reviewers
Frameworks
Summary

We're about to get proper backends for Windows (D21661) and macOS (D22365). Judging by the code and comments this backend was never properly implemented anyway and will be dead code

Diff Detail

Repository
R289 KNotifications
Branch
growl
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14064
Build 14082: arc lint + arc unit
nicolasfella created this revision.Jul 17 2019, 10:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJul 17 2019, 10:28 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Jul 17 2019, 10:28 PM
  • Remove unneeded include
nicolasfella edited the summary of this revision. (Show Details)Jul 17 2019, 10:31 PM
broulik accepted this revision.Jul 18 2019, 7:14 AM

(Once the replacement backends are actually in)

src/notifybypopupgrowl.cpp
27

lol

This revision is now accepted and ready to land.Jul 18 2019, 7:14 AM